Global markdown mode remake based on Scopes #4923
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/editor.js # src/mode/markdown.js
nightwing
force-pushed
the
scopes-markdown
branch
from
19ba118 to
1a14040
Compare
…kdown # Conflicts: # src/edit_session/folding.js # src/layer/text.js # src/mode/_test/highlight_rules_test.js # src/mode/behaviour/behaviour_test.js # src/mode/text.js # src/scope.js # src/tokenizer.js # src/tooltip.js
nightwing
reviewed
Aug 13, 2024
| var parent = scope.get("codeBlock" + language); | ||
| parent.language = language; | ||
| parent.indent = m[1].length; | ||
| parent.endMarker = m[2]; |
There was a problem hiding this comment.
this code is broken because it is changing properties on the same scope object, it should be something like parent.get(this.next, {language, indent, marker, toString() { [language, indent, marker].join("|") }})`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #3942, #3750, #2595, #2950, #5056, #4358, #1390
Would fix after implementing embedded scope-based/normal modes: #2978
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.